Broken labels in existing games #759

New issue

Open

opened 2026-02-20 10:20:18 -05:00 by deekerman · 3 comments

deekerman commented

2026-02-20 10:20:18 -05:00

Owner

Originally created by @96LawDawg on GitHub (Dec 22, 2023).

#1033 fixed some problems, but created others. Labels in some existing games either have scrollbars where they did not exist before and do not need them (example, Yoink). Or the text in the label is cut off (example, Find the Word).

Git bisect says commit aeb6d51424

Originally created by @96LawDawg on GitHub (Dec 22, 2023). #1033 fixed some problems, but created others. Labels in some existing games either have scrollbars where they did not exist before and do not need them (example, Yoink). Or the text in the label is cut off (example, Find the Word). Git bisect says commit aeb6d51424917762ff5e062503518e058589a115

deekerman added the

bug

widget properties

labels

2026-02-20 10:20:18 -05:00

deekerman commented

2026-02-20 10:20:19 -05:00

Author

Owner

@96LawDawg commented on GitHub (Dec 22, 2023):

For Yoink, I think it was a combination of the label changes and the file updater. Look at the score labels at the top of the screen. On the far left is "score1". Currently, that label has a height of 47 and a css font-size of 45px. In the original implementation, the height was 40 and the font-size was 45. That worked because of the old way that labels worked. The file updater forced the height to be 47, but that still is not quite big enough. The height needs to be 50.

@96LawDawg commented on GitHub (Dec 22, 2023): For Yoink, I think it was a combination of the label changes and the file updater. Look at the score labels at the top of the screen. On the far left is "score1". Currently, that label has a height of 47 and a css font-size of 45px. In the original implementation, the height was 40 and the font-size was 45. That worked because of the old way that labels worked. The file updater forced the height to be 47, but that still is not quite big enough. The height needs to be 50.

deekerman commented

2026-02-20 10:20:19 -05:00

Author

Owner

@96LawDawg commented on GitHub (Dec 22, 2023):

Find the Word messed up for a different reason. Sit in the left seat and look at the label "word_1". The top padding is off. There is some code in #1033 that messes with the padding and twoRowBottomAlign. If I add twoRowBottomAlign to the label in Find the Word, the labels work. That property was not originally in the label when the game was created. But something with the top padding is now broken.

@96LawDawg commented on GitHub (Dec 22, 2023): Find the Word messed up for a different reason. Sit in the left seat and look at the label "word_1". The top padding is off. There is some code in #1033 that messes with the padding and twoRowBottomAlign. If I add twoRowBottomAlign to the label in Find the Word, the labels work. That property was not originally in the label when the game was created. But something with the top padding is now broken.

deekerman commented

2026-02-20 10:20:19 -05:00

Author

Owner

@96LawDawg commented on GitHub (Dec 23, 2023):

I went through every PL game with labels. Most of them were fine. Most of them only used the label that is part of the +/- score widget. But here are the ones that were most likely effected by the change.

**Dots
Score labels cut off

**Dungeon Speeders
Letter labels have scroll bars

**Rackball
Name labels cut off

**Yoink
Score labels have scroll bars

@96LawDawg commented on GitHub (Dec 23, 2023): I went through every PL game with labels. Most of them were fine. Most of them only used the label that is part of the +/- score widget. But here are the ones that were most likely effected by the change. **Dots Score labels cut off **Dungeon Speeders Letter labels have scroll bars **Rackball Name labels cut off **Yoink Score labels have scroll bars