setting `stackOffsetX` from `0` to `40` offsets the cards inside the pile #835

New issue

Open

opened 2026-02-20 10:20:56 -05:00 by deekerman · 1 comment

deekerman commented

2026-02-20 10:20:56 -05:00

Owner

Originally created by @ArnoldSmith86 on GitHub (Sep 22, 2024).

QuickDownload without assets 2024-09-22 2003 - Unnamed.vtt.zip

Click Offset 40 in the top right.

It doesn't do anything in hand.

Also: setting it back to 0 doesn't do anything.

Originally created by @ArnoldSmith86 on GitHub (Sep 22, 2024). [QuickDownload without assets 2024-09-22 2003 - Unnamed.vtt.zip](https://github.com/user-attachments/files/17091045/QuickDownload.without.assets.2024-09-22.2003.-.Unnamed.vtt.zip) Click `Offset 40` in the top right. It doesn't do anything in `hand`. Also: setting it back to `0` doesn't do anything.

deekerman added the

bug

pile related

widget properties

labels

2026-02-20 10:20:56 -05:00

deekerman commented

2026-02-20 10:20:58 -05:00

Author

Owner

@bjalder26 commented on GitHub (Oct 26, 2024):

It looks like these are the related functions in holder.js:

  async onPropertyChange(property, oldValue, newValue) {
    await super.onPropertyChange(property, oldValue, newValue);
    if(property == 'dropOffsetX' || property == 'dropOffsetY' || property == 'stackOffsetX' || property == 'stackOffsetY') {
      await this.updateAfterShuffle();
    }
  }

async updateAfterShuffle() {
    if(!this.get('stackOffsetX') && !this.get('stackOffsetY'))
      return;

    const children = this.children();
    for(const owner of new Set(children.map(c=>c.get('owner')))) {
      await this.rearrangeChildren(children.filter(c=>!c.get('owner') || c.get('owner')===owner).sort((a, b)=>{
        return a.get('z') - b.get('z');
      }));
    }
  }
}

async rearrangeChildren(children, card) {
    if(this.preventRearrangeDuringPileDrop)
      return;

    let xOffset = 0;
    let yOffset = 0;
    let z = 1;

    for(const child of children) {
      const newX = this.get('dropOffsetX') + xOffset;
      const newY = this.get('dropOffsetY') + yOffset;
      const newZ = z++;

      await child.setPosition(newX, newY, newZ);

      xOffset += !child.get('overlap') && this.get('stackOffsetX') ? child.get('width' ) + 4 : this.get('stackOffsetX');
      yOffset += !child.get('overlap') && this.get('stackOffsetY') ? child.get('height') + 4 : this.get('stackOffsetY');
    }
  }

stackOffsetX: 0 evaluates as a null value, so !this.get('stackOffsetX') will evaluate as true in updateAfterShuffle() and it will just return rather than updating.

I'm not sure how the piles should behave when stackOffsetX or stackOffsetY are updated, but it looks like currently they don't break the pile (and reset the parent to the holder) and they offset cards from the pile.

It seems like the workaround for this would be to preventPiles on the holder, then set the stackOffsetY to 0.0000001.

@bjalder26 commented on GitHub (Oct 26, 2024): It looks like these are the related functions in holder.js: ```js async onPropertyChange(property, oldValue, newValue) { await super.onPropertyChange(property, oldValue, newValue); if(property == 'dropOffsetX' || property == 'dropOffsetY' || property == 'stackOffsetX' || property == 'stackOffsetY') { await this.updateAfterShuffle(); } } async updateAfterShuffle() { if(!this.get('stackOffsetX') && !this.get('stackOffsetY')) return; const children = this.children(); for(const owner of new Set(children.map(c=>c.get('owner')))) { await this.rearrangeChildren(children.filter(c=>!c.get('owner') || c.get('owner')===owner).sort((a, b)=>{ return a.get('z') - b.get('z'); })); } } } async rearrangeChildren(children, card) { if(this.preventRearrangeDuringPileDrop) return; let xOffset = 0; let yOffset = 0; let z = 1; for(const child of children) { const newX = this.get('dropOffsetX') + xOffset; const newY = this.get('dropOffsetY') + yOffset; const newZ = z++; await child.setPosition(newX, newY, newZ); xOffset += !child.get('overlap') && this.get('stackOffsetX') ? child.get('width' ) + 4 : this.get('stackOffsetX'); yOffset += !child.get('overlap') && this.get('stackOffsetY') ? child.get('height') + 4 : this.get('stackOffsetY'); } } ``` stackOffsetX: 0 evaluates as a null value, so !this.get('stackOffsetX') will evaluate as true in updateAfterShuffle() and it will just return rather than updating. I'm not sure how the piles should behave when stackOffsetX or stackOffsetY are updated, but it looks like currently they don't break the pile (and reset the parent to the holder) and they offset cards from the pile. It seems like the workaround for this would be to preventPiles on the holder, then set the stackOffsetY to 0.0000001.