mirror of
https://github.com/ArnoldSmith86/virtualtabletop.git
synced 2026-03-02 22:57:02 -05:00
ESC key when in fullscreen #94
Labels
No labels
PCIO compatibility
Validator
automated testing
bug
documentation
duplicate
editor
enhancement
enhancement
library
library
maintenance
needs legacy server
pile related
reported client crash
routine operations
user interface
widget properties
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/virtualtabletop#94
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Ingegneus on GitHub (Jan 28, 2021).
This is a little QOL issue: when editing a widget in fullscreen mode, pressing esc exits fullscreen instead of the editor. Same thing when using the debug function.
@ArnoldSmith86 commented on GitHub (Jan 28, 2021):
I don't think we can change that. I'm pretty sure the browser uses the ESC without ever telling the page about it.
@robartsd commented on GitHub (Jan 28, 2021):
I think it depends partially on how one enters fullscreen. On Chrome, if I use the fullscreen button that VTT provides, ESC exits fullscreen, but I can enter fullscreen using the browser's menus and only F11 exits fullscreen (F11 toggles fullscreen regardless of how it was entered). I don't think we can change this browser behavior. If users want to stay in fullscreen more easily, they can use their browser controls to enter fullscreen.
I think we should provide a clear and direct way to exit each overlay with a click/touch (close box or cancel button on every overlay).
@bjalder26 commented on GitHub (Jun 6, 2021):
I believe PR #519 addresses this.
On edit: I guess it still exits full screen first if you used the button to enter full screen. However, if you use F11, then it will exit debug first, then the JSON editor, and not full screen.