mirror of
https://github.com/requarks/wiki.git
synced 2026-03-02 22:06:55 -05:00
Authentication Advanced Global Settings don't save #1578
Labels
No labels
BETA
BETA
accessibility
backlog
bug
can't replicate
contrib-easy
contrib-hard
contrib-medium
deferred
documentation
duplicate
duplicate
editors
enhancement
invalid
localization
migrate
ui
under review
v3
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/wiki-requarks#1578
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @preems1 on GitHub (May 28, 2020).
Originally assigned to: @NGPixel on GitHub.
Describe the bug
Advanced Global Settings in Admin>Authentication reset to default after being changed and saved.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Advanced Global Settings will be saved
Host Info (please complete the following information):
Additional context
I have the Keycloak module active but I have experienced this error without Keycloak module.
@ftm commented on GitHub (Jun 25, 2020):
I am also experiencing this, however after doing some digging it looks like it's (at least partially) a UI bug.
When I update the audience from
urn:wiki.jstourn:mywiki.example.comand click Apply, my token is invalidated as expected and I am forced to log back in. After logging back in, the audience field reverts back tourn:wiki.js.However, when I decode the JWT I can see that the audience is correct, and in the database I can see that the audience has indeed been updated:
If I then click Apply again, the default value of
urn:wiki.jsis saved over my custom audience and the token is once again made invalid.From a look at
admin-auth.vueit seems like the audience, token expiration and token renewal values are all being saved but there isn't a query to actually retrieve the values back again.@NGPixel commented on GitHub (Jun 28, 2020):
Fixed for 2.5.