mirror of
https://github.com/requarks/wiki.git
synced 2026-03-02 22:06:55 -05:00
Login screen is not fully localised #2027
Labels
No labels
BETA
BETA
accessibility
backlog
bug
can't replicate
contrib-easy
contrib-hard
contrib-medium
deferred
documentation
duplicate
duplicate
editors
enhancement
invalid
localization
migrate
ui
under review
v3
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/wiki-requarks#2027
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @madodig on GitHub (Sep 13, 2020).
Originally assigned to: @NGPixel on GitHub.
Describe the bug
Terms "Select Authentication Provider" and "Enter your credentials" in Login screen are not shown in Base locale (they are shown in English) because they are hard-coded (assets/js/login.js).
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Login screen is fully localized.
To fix, please switch from hard-coding to localization keys for the values, e.g.:
Host Info:
Additional context
Tested with Croatian Base locale, verified in the corresponding assets JS file.
Bug is not specific to the latest version.
There are other terms that are not localized as well, but they are under Administration area hence they do not impact UX of a regular user. It would be great to have wiki completely localisable, though.
@NGPixel commented on GitHub (Sep 13, 2020):
Fixed by
e782f85a1d