1
0
Fork 0
mirror of https://github.com/requarks/wiki.git synced 2026-03-02 22:06:55 -05:00

Login screen is not fully localised #2027

Closed
opened 2026-02-20 18:26:48 -05:00 by deekerman · 1 comment
Owner

Originally created by @madodig on GitHub (Sep 13, 2020).

Originally assigned to: @NGPixel on GitHub.

Describe the bug
Terms "Select Authentication Provider" and "Enter your credentials" in Login screen are not shown in Base locale (they are shown in English) because they are hard-coded (assets/js/login.js).

To Reproduce
Steps to reproduce the behavior:

  1. Change Base Locale under Administration / Locale / Locale Settings to a language other than English and click Apply;
  2. Logout;
  3. Navigate to Login screen;
  4. Login screen is shown in selected Base locale, except for the terms:
    • "Select Authentication Provider";
    • "Enter your credentials".

Expected behavior
Login screen is fully localized.
To fix, please switch from hard-coding to localization keys for the values, e.g.:

"auth:strategy.title": "Select Authentication Provider",
"auth:credentials.title": "Enter your credentials"

Host Info:

  • OS: CentOS Linux release 8.2.2004 (Core)
  • Wiki.js version: 2.5.136
  • Database engine: PostgreSQL 12.1

Additional context
Tested with Croatian Base locale, verified in the corresponding assets JS file.
Bug is not specific to the latest version.
There are other terms that are not localized as well, but they are under Administration area hence they do not impact UX of a regular user. It would be great to have wiki completely localisable, though.

Originally created by @madodig on GitHub (Sep 13, 2020). Originally assigned to: @NGPixel on GitHub. **Describe the bug** Terms "Select Authentication Provider" and "Enter your credentials" in Login screen are not shown in Base locale (they are shown in English) because they are hard-coded (assets/js/login.js). **To Reproduce** Steps to reproduce the behavior: 1. Change Base Locale under Administration / Locale / Locale Settings to a language other than English and click Apply; 2. Logout; 3. Navigate to Login screen; 4. Login screen is shown in selected Base locale, except for the terms: - "Select Authentication Provider"; - "Enter your credentials". **Expected behavior** Login screen is fully localized. To fix, please switch from hard-coding to localization keys for the values, e.g.: ``` "auth:strategy.title": "Select Authentication Provider", "auth:credentials.title": "Enter your credentials" ``` **Host Info:** - OS: CentOS Linux release 8.2.2004 (Core) - Wiki.js version: 2.5.136 - Database engine: PostgreSQL 12.1 **Additional context** Tested with Croatian Base locale, verified in the corresponding assets JS file. Bug is not specific to the latest version. There are other terms that are not localized as well, but they are under Administration area hence they do not impact UX of a regular user. It would be great to have wiki completely localisable, though.
deekerman 2026-02-20 18:26:48 -05:00
Author
Owner

@NGPixel commented on GitHub (Sep 13, 2020):

Fixed by e782f85a1d

@NGPixel commented on GitHub (Sep 13, 2020): Fixed by e782f85a1da9f2a9c1dd5659777e3cf134b5e1cb
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/wiki-requarks#2027
No description provided.