1
0
Fork 0
mirror of https://github.com/requarks/wiki.git synced 2026-03-02 22:06:55 -05:00

Small Usability Change when adding Git Repo #544

Open
opened 2026-02-20 17:15:58 -05:00 by deekerman · 0 comments
Owner

Originally created by @ndom91 on GitHub (Apr 22, 2019).

Originally assigned to: @NGPixel on GitHub.

This is regarding 2.0.0-beta.84

When adding an HTTP (Basic) git repo as a storage backend, the helper text tells the user to enter it in the format: https://github.com/org/repo.git

However, in the backend code, it does the following:

await this.git.addRemote('origin', `https://${this.config.basicUsername}:${this.config.basicPassword}@${this.config.repoUrl}`) 

Which means, it would try to add the following repo and fail: https://user:password@https://github.com/org/repo.git

Maybe edit that to make it clear to add the URL without the protocol (https).

I just had this issue, fortunately it was easy to figure out, but others may not be so quick to find where the issue lay in the future.

See Screenshot:
image

Originally created by @ndom91 on GitHub (Apr 22, 2019). Originally assigned to: @NGPixel on GitHub. This is regarding 2.0.0-beta.84 When adding an HTTP (Basic) git repo as a storage backend, the helper text tells the user to enter it in the format: `https://github.com/org/repo.git` However, in the backend code, it does the following: ```js await this.git.addRemote('origin', `https://${this.config.basicUsername}:${this.config.basicPassword}@${this.config.repoUrl}`) ``` Which means, it would try to add the following repo and fail: `https://user:password@https://github.com/org/repo.git` Maybe edit that to make it clear to add the URL **without** the protocol (https). I just had this issue, fortunately it was easy to figure out, but others may not be so quick to find where the issue lay in the future. See Screenshot: ![image](https://user-images.githubusercontent.com/7415984/56505110-f6761680-651a-11e9-946e-672506b69611.png)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/wiki-requarks#544
No description provided.