mirror of
https://github.com/requarks/wiki.git
synced 2026-03-02 22:57:36 -05:00
WYSIWYG editor: "Insert media" not displaying embedded content in front-end #802
Labels
No labels
BETA
BETA
accessibility
backlog
bug
can't replicate
contrib-easy
contrib-hard
contrib-medium
deferred
documentation
duplicate
duplicate
editors
enhancement
invalid
localization
migrate
ui
under review
v3
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/wiki#802
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @carloposo on GitHub (Oct 24, 2019).
Originally assigned to: @NGPixel on GitHub.
Actual behavior
Embedded media (for example, a YouTube or Vimeo video) is correctly shown in WYSIWYG editor, but it is not in the final page (front-end).
Expected behavior
Embedded media is shown in the front-end.
Steps to reproduce the behavior
@anibal-aguila commented on GitHub (Feb 4, 2020):
same issue here
@ideasandpixels commented on GitHub (Aug 19, 2020):
Same issue here. Looks like a very old issue -- any ideas?
@nideKer commented on GitHub (Aug 22, 2020):
Same issue here. Is there any chance to fix it?
@mrUlrik commented on GitHub (Oct 2, 2020):
I thought this was perhaps related to security settings such as embedding IFrame found in Admin > Security > Block IFrame Embedding or perhaps some kind of Cross-Site security issue. But after seeing no errors Console or Network I see that the rendered document simply doesn't include any information in the
<figure>tag despite the fact that it shows at least a thumbnail of the content in the WYSIWYG editor.The example below was created with a random Youtube video. The WYSIWYG editor displayed the video's thumbnail properly, but it's never rendered on the actual page.
@mtrip commented on GitHub (Oct 2, 2020):
Same issue
@ryanmasuga commented on GitHub (Oct 9, 2020):
We just installed Wiki.js and the first thing I tried was embedding a YouTube video on a WYSIWYG page and I immediately ran into this. This has been open nearly a year at this point.
According to this other issue (https://github.com/Requarks/wiki/issues/1459), from Feb 2020 "Videos are not yet supported in the rendering pipeline." Maybe this issue should be closed if the most up-to-date discussion about it is over there.
@TheBigShort111 commented on GitHub (Feb 24, 2021):
Feb 24 2021 - Same issues here
@Jsmithrud37 commented on GitHub (Mar 7, 2021):
Running into this as well.
@radialbalance commented on GitHub (Mar 9, 2021):
Same! I tried changing the Santize HTML & Rendering Security, but still no luck.
@MaxWaldorf commented on GitHub (Jun 8, 2021):
Would like to see this feature fully implemented as well...
Cheers
@grandixximo commented on GitHub (Jul 31, 2021):
Credits to @NGPixel @stukev and @BitWiseSE
for who did not follow the conversation over in the other bug report #1459
DISABLE rendering => HTML => security => Sanitize HTML
add this in your theme CSS Override
and this to your HTML injection
This will embed Youtube Vimeo and local mp4 in your WYSIWYG pages.
How it works:
It scans your page once after it's fully loaded, it finds the 'broken' tags, and mp4 links, and substitutes them with iframes and videos tags that display 640x360 embedded video if sanitize HTML is disabled. The CSS makes the videos fit on mobile screens, use at your own discretion.
@hardline7 commented on GitHub (Nov 27, 2024):
I can't believe this is still not resolved....
@BPowell76 commented on GitHub (Nov 27, 2024):
The issue is more of a site settings issue then an application problem. By default, iframes are disabled. If you allow iframes, you can embed videos into a page.
@TheTerrasque commented on GitHub (Dec 9, 2024):
How about letting me just put a html link to a youtube video? Because now it automatically get converted to an embedding, which doesn't work. I'm literally unable to add a youtube link via the visual editor. Not a video embedding, a link. Because it automatically gets converted to an embedding.
@BPowell76 commented on GitHub (Dec 10, 2024):
I'm confused. Are you referring to just putting a link to a video on YouTube to watch it there or have the link be automatically converted to an embed on the page?
If you're copying something from YouTube one of the export/share options is to embed it. For example, I just need to paste this into any Markdown page with iframes enabled to Rick Roll people.
Now that being said, make sure you have a blank line between the markdown and html tags for it to render properly.
@TheTerrasque commented on GitHub (Dec 10, 2024):
Just putting a link.