We need tests. Really. #266

Closed
opened 2026-02-20 22:30:35 -05:00 by deekerman · 4 comments
Owner

Originally created by @FiloSottile on GitHub (Jul 6, 2012).

Originally assigned to: @FiloSottile on GitHub.

This will be far easier as we advance to an API (#152)
Anyway, I think we should put up some green/red tests, let's say a download (video and info) + md5 test for a set of videos. This because we are really prone to regressions and we have broken IEs every month. It would be better to catch them immediately than to wait for bug reports.

Then, also some unit test for some features would be pretty, but that is secondary.

Suggestions on which framework to use (that IMHO should be the more easy/simple/barebones possible)? Or we are better building our own?

P.S. I am using a new tag "broken-IE" in the issue tracker, feel free to delete it if you don't like it. (And tell me if I am too bold!)

Originally created by @FiloSottile on GitHub (Jul 6, 2012). Originally assigned to: @FiloSottile on GitHub. This will be far easier as we advance to an API (#152) Anyway, I think we should put up some green/red tests, let's say a download (video and info) + md5 test for a set of videos. This because we are really prone to regressions and we have broken IEs every month. It would be better to catch them immediately than to wait for bug reports. Then, also some unit test for some features would be pretty, but that is secondary. Suggestions on which framework to use (that IMHO should be the more easy/simple/barebones possible)? Or we are better building our own? P.S. I am using a new tag "broken-IE" in the issue tracker, feel free to delete it if you don't like it. (And tell me if I am too bold!)
Author
Owner

@rg3 commented on GitHub (Jul 6, 2012):

There's a unit testing package in Python:

http://docs.python.org/library/test.html#module-test

@rg3 commented on GitHub (Jul 6, 2012): There's a unit testing package in Python: http://docs.python.org/library/test.html#module-test
Author
Owner

@FiloSottile commented on GitHub (Jul 6, 2012):

It seemed an overkill and a bit difficult to use seen the lack of an (our) API, but effectively it might be a good fit to test the info_dicts returned by the IEs, and that is what matters.
I will try to implement something in my fork :)

@FiloSottile commented on GitHub (Jul 6, 2012): It seemed an overkill and a bit difficult to use seen the lack of an (our) API, but effectively it might be a good fit to test the `info_dict`s returned by the IEs, and that is what matters. I will try to implement something in my fork :)
Author
Owner

@gcmalloc commented on GitHub (Sep 28, 2012):

I implemented a little testing example on my fork, I have some issue with the direct call to one of the file downloader.

@gcmalloc commented on GitHub (Sep 28, 2012): I implemented a little testing example on my fork, I have some issue with the direct call to one of the file downloader.
Author
Owner

@FiloSottile commented on GitHub (Oct 30, 2012):

We now have them, thanks to @gcmalloc.
They will need expansion (and integration... um... The Travis CI thing @rg3 😈) but this will come with time. Closing.

@FiloSottile commented on GitHub (Oct 30, 2012): We now have them, thanks to @gcmalloc. They will need expansion (and integration... um... The Travis CI thing @rg3 :smiling_imp:) but this will come with time. Closing.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/youtube-dl-ytdl-org#266
No description provided.