mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Exclude certain domains / IPs from statistics #1601
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#1601
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @adrianmace on GitHub (May 22, 2020).
Originally assigned to: @schzhn on GitHub.
Prerequisites
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.
Problem Description
A number of devices - monitoring and updaters - check frequently for the same hostnames. Due to the fact that the TTL is overriden by Adguardhome, these checks greatly skew the statistics. My monitoring device makes 21,600 requests to google.com a day - one every 4 seconds - for example.
My Swann cameras have a bug that's causing a lookup every 5 seconds to www.amazonaws.com. 17,280 times per 24 hours.
Proposed Solution
Offer a way to remove certain domains (www.amazonaws.com) and certain IPs (192.168.1.2) from the statistics gathering process. Still apply the same customised filters and what not, but remove them from the statistics.
Alternatives Considered
Currently bypassing the Adguardhome for these devices affected and going straight to upstream DNS.
Additional Information
PiHole has this, but I like Adguardhome's UI and static Go binary more.
@ameshkov commented on GitHub (May 22, 2020):
Well, let's see how many upvotes it gets.
@adrianmace commented on GitHub (May 22, 2020):
Thanks for getting back to me. All the best.
@ameshkov commented on GitHub (May 22, 2020):
One more similar feature request:
https://github.com/AdguardTeam/AdGuardHome/issues/1714
@Aikatsui commented on GitHub (May 22, 2020):
Suggestion: implement this feature on single control panel https://github.com/AdguardTeam/AdGuardHome/issues/481#issuecomment-515673586 in query log then user can apply complex/flexible rules, filters, sorts (date range, time range, hide unwanted domains https://github.com/AdguardTeam/AdGuardHome/issues/594#issuecomment-469129412, hide clients, sort for certain devices) etc and then generate result for web-app wide including dashboard, lists pages (see -->#580), client page (see --> https://github.com/AdguardTeam/AdGuardHome/issues/1336) and keep till user edit or clear it manually same as github.
If add control panel(s) to dashboard then it takes unwanted space but it'll be better if dashboard results (total queries, malware/phishing, adult queries, processing time, top clients, domains top blocked clients, domains etc) able to manage through query log control panel as mentioned above
Similar feature requests #1714 > #594 https://github.com/AdguardTeam/AdGuardHome/issues/594#issuecomment-469129412
Optionally, you can get benefit from #1164 (Collapse feature)
@adrianmace commented on GitHub (May 24, 2020):
Some images to highlight the problem:
@ameshkov commented on GitHub (May 24, 2020):
I wonder would it be enough if we simply add a Client setting: "Do not log queries"?
@adrianmace commented on GitHub (May 24, 2020):
That would work for me. The reason they’re named is because I set that up in my search for this setting before realising it didn’t exist.
I’d like to eventually be able to exclude domains, but per-client is good enough if it’s easier / faster to develop.
@Aikatsui commented on GitHub (May 24, 2020):
If implement, Would it be possible to mod it bit: "Do not display queries"? so we still have them to check when necessary and again user has chance to enable/disable that "do not display" option through client settings.
@Buddinski88 commented on GitHub (Jan 11, 2022):
Is there any info here on when this feature will be ready?
I currently have 120k requests in the log coming from my RaspberryPi with Raspberrymatic. Every 15 seconds it checks against my Fritzbox if two devices are online (presence detection). This distorts the statistics enormously :-)
@ameshkov commented on GitHub (Jan 11, 2022):
Will only be done after the frontend rework.
Tbh, I'd like to keep this feature purely on the UI side (show smth like "X domains are hidden (N requests)").
@Buddinski88 commented on GitHub (Jan 11, 2022):
Thank you for the update.
In general that seems to be fine. Will that count then also be excluded from the statistics?
@ameshkov commented on GitHub (Jan 11, 2022):
No, if it's purely frontend we won't be able to get rid of them there.
@Buddinski88 commented on GitHub (Feb 2, 2022):
First of all, thank you for your feedback and sorry that it took me so long.
Basically I understand your answer, but it would only provide a real added value if the numbers are also excluded from the statistics. For example, the statement "5%" requests were blocked would be appropriate.
I think this adjustment is not a short term issue, but for the future - I think - everyone would benefit from exculpating certain devices from the statistics. Example from my side. Due to presence detection, my smarthome system asks my Fritzbox every 30 seconds if two devices are logged into the WLAN. That's X thousands of requests in a few days and that distorts the statistics enormously.
@danieletorelli commented on GitHub (Feb 2, 2022):
Sometimes you might just want to hide some queries from the statistics, while some other times you might not even care of recording some queries at all.
I suppose that leaving the user free to choose would provide way better added value in both cases, since IMO the use cases are so vary that all assumptions here could be misleading.
@MattXcz commented on GitHub (Mar 30, 2022):
I am also +1 for this future request... I have some IOT clients, which spam query log and statistics
@Toxicolo commented on GitHub (Mar 31, 2022):
+1 from my side. Would really nice to a a filter or exclude option!
@NemoN commented on GitHub (Mar 31, 2022):
+1 really an important feature
@MSlawik commented on GitHub (Mar 31, 2022):
+1 !!!!
@jamboc88 commented on GitHub (Mar 31, 2022):
+1 !!
@ameshkov commented on GitHub (Mar 31, 2022):
Okay, it's too popular to keep it on v1.0.0. We're doing the frontend rework&redesign in v0.108.0, let's squeeze this one there as well.
@MattXcz commented on GitHub (Mar 31, 2022):
Stats + query log too.So we dont have these request over and over in log
@HyperCriSiS commented on GitHub (Jul 23, 2022):
I also have devices which do HUGE amounts of querys of one or more domains. It would be good to be able to drop specific domains completely. No log at all.
@danbo commented on GitHub (Oct 1, 2022):
I was going to ask about a slightly different feature - separate statistics out by interface or subnet.
Ultimately I think we're all saying the same thing here - we would very much appreciate a way to filter noise out of statistics. (domain/ips/subnets/interfaces)
@nemo-ex commented on GitHub (Mar 10, 2023):
+1
@ainar-g commented on GitHub (Mar 10, 2023):
@jiangmw, please use reactions on the OP instead of “+1”-like comments. Thanks.
In case people watching this issue have missed it, the most recent releases of AdGuard Home have the feature of ignoring requests by their query domain names, but it's currently only available through the configuration file. API and UI are coming soon.
@ainar-g commented on GitHub (Apr 18, 2023):
Implemented for both domains and clients on Edge and in the upcoming release.
@rfgamaral commented on GitHub (May 15, 2023):
Is it possible to ignore wildcard domains? Adding
*.example.comdoesn't seem to be working :(@don-dolarson commented on GitHub (Jun 30, 2023):
Wildcards doesn't seem to work for me neither on latest v0.107.32. Anyone else?
@ainar-g commented on GitHub (Jun 30, 2023):
@rfgamaral, @don-dolarson, they aren't supported now. Please upvote #5720. (Do not post “+1” comments as one cannot sort by those in Github; a “👍” reaction on the top comment is enough.)