mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Support for domain auditing #1639
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#1639
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @yegle on GitHub (Jun 2, 2020).
Prerequisites
Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.
Problem Description
There's an audit feature in PiHole. It gives you the top permitted and blocked domains. For each of them you can mark it as "audited" indicating you are ok with it being permitted/blocked. The audited domain will no longer appear on the audit page.
This is useful to examine the full list of the domains from your network, and to identify missed ad/tracking domains from the permitted domains list.
(See also https://pi-hole.net/2017/12/06/pi-hole-v3-2-introduces-long-term-statistics-an-audit-log-colours-and-more/)
Proposed Solution
Support auditing the top permitted/blocked domains.
Alternatives Considered
Additional Information
@Aikatsui commented on GitHub (Jun 2, 2020):
How about #1164? and it can filter based on time or category as mentioned above blocked domains
@yegle commented on GitHub (Jun 2, 2020):
I think they are different. The audit feature ensures I can review every permitted domain and with no duplicated effort. The linked feature looks like I can periodically review top permitted domains but I may look at the exact same list of top permitted domains everytime?
@yegle commented on GitHub (Jun 2, 2020):
Hmm I think what I need is on top of #1164, by adding a "hide this domain" button as the rightmost column in the collapsed view, so I can slowly go over all permitted domain.
If this can be implemented it would be more powerful than PiHole's audit feature. In PiHole you can only audit the permitted list from all clients, whereas in AdGuard Home we can focused on certain clients and audit them first.
@ameshkov commented on GitHub (Jun 2, 2020):
This is an interesting idea indeed, let's see how many upvotes it gets.
@Aikatsui commented on GitHub (Jun 2, 2020):
While this feature adds to query log; you can definitely get benefit from many other features than i mentioned above (time range, category blocked, malware, adult) and client range, hide domains https://github.com/AdguardTeam/AdGuardHome/issues/594#issuecomment-469129412, realtime features and other. you can find more on 'query log cosmetic changes'