Support for domain auditing #1639

Open
opened 2026-03-04 01:26:18 -05:00 by deekerman · 5 comments
Owner

Originally created by @yegle on GitHub (Jun 2, 2020).

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Problem Description

There's an audit feature in PiHole. It gives you the top permitted and blocked domains. For each of them you can mark it as "audited" indicating you are ok with it being permitted/blocked. The audited domain will no longer appear on the audit page.

This is useful to examine the full list of the domains from your network, and to identify missed ad/tracking domains from the permitted domains list.

(See also https://pi-hole.net/2017/12/06/pi-hole-v3-2-introduces-long-term-statistics-an-audit-log-colours-and-more/)

Proposed Solution

Support auditing the top permitted/blocked domains.

Alternatives Considered

Additional Information

Originally created by @yegle on GitHub (Jun 2, 2020). <!-- As an open-source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can. --> ### Prerequisites Please answer the following questions for yourself before submitting an issue. **YOU MAY DELETE THE PREREQUISITES SECTION.** - [x] I am running the latest version - [x] I checked the documentation and found no answer - [x] I checked to make sure that this issue has not already been filed ### Problem Description <!-- Is your feature request related to a problem? Please add a clear and concise description of what the problem is. --> There's an audit feature in PiHole. It gives you the top permitted and blocked domains. For each of them you can mark it as "audited" indicating you are ok with it being permitted/blocked. The audited domain will no longer appear on the audit page. This is useful to examine the full list of the domains from your network, and to identify missed ad/tracking domains from the permitted domains list. (See also https://pi-hole.net/2017/12/06/pi-hole-v3-2-introduces-long-term-statistics-an-audit-log-colours-and-more/) ### Proposed Solution <!-- Describe the solution you'd like in a clear and concise manner --> Support auditing the top permitted/blocked domains. ### Alternatives Considered <!-- A clear and concise description of any alternative solutions or features you've considered. --> ### Additional Information <!-- Add any other context about the problem here. -->
Author
Owner

@Aikatsui commented on GitHub (Jun 2, 2020):

How about #1164? and it can filter based on time or category as mentioned above blocked domains

@Aikatsui commented on GitHub (Jun 2, 2020): How about #1164? and it can filter based on time or category as mentioned above blocked domains
Author
Owner

@yegle commented on GitHub (Jun 2, 2020):

I think they are different. The audit feature ensures I can review every permitted domain and with no duplicated effort. The linked feature looks like I can periodically review top permitted domains but I may look at the exact same list of top permitted domains everytime?

@yegle commented on GitHub (Jun 2, 2020): I think they are different. The audit feature ensures I can review every permitted domain and with no duplicated effort. The linked feature looks like I can periodically review top permitted domains but I may look at the exact same list of top permitted domains everytime?
Author
Owner

@yegle commented on GitHub (Jun 2, 2020):

Hmm I think what I need is on top of #1164, by adding a "hide this domain" button as the rightmost column in the collapsed view, so I can slowly go over all permitted domain.

If this can be implemented it would be more powerful than PiHole's audit feature. In PiHole you can only audit the permitted list from all clients, whereas in AdGuard Home we can focused on certain clients and audit them first.

@yegle commented on GitHub (Jun 2, 2020): Hmm I think what I need is on top of #1164, by adding a "hide this domain" button as the rightmost column in the collapsed view, so I can slowly go over all permitted domain. If this can be implemented it would be more powerful than PiHole's audit feature. In PiHole you can only audit the permitted list from all clients, whereas in AdGuard Home we can focused on certain clients and audit them first.
Author
Owner

@ameshkov commented on GitHub (Jun 2, 2020):

This is an interesting idea indeed, let's see how many upvotes it gets.

@ameshkov commented on GitHub (Jun 2, 2020): This is an interesting idea indeed, let's see how many upvotes it gets.
Author
Owner

@Aikatsui commented on GitHub (Jun 2, 2020):

@yegle Hmm I think what I need is on top of #1164,
If this can be implemented it would be more powerful than PiHole's audit feature. In PiHole you can only audit the permitted list from all clients, whereas in AdGuard Home we can focused on certain clients and audit them first.

While this feature adds to query log; you can definitely get benefit from many other features than i mentioned above (time range, category blocked, malware, adult) and client range, hide domains https://github.com/AdguardTeam/AdGuardHome/issues/594#issuecomment-469129412, realtime features and other. you can find more on 'query log cosmetic changes'

@Aikatsui commented on GitHub (Jun 2, 2020): > @yegle Hmm I think what I need is on top of #1164, > If this can be implemented it would be more powerful than PiHole's audit feature. In PiHole you can only audit the permitted list from all clients, whereas in AdGuard Home we can focused on certain clients and audit them first. While this feature adds to query log; you can definitely get benefit from many other features than i mentioned above (time range, category blocked, malware, adult) and client range, hide domains https://github.com/AdguardTeam/AdGuardHome/issues/594#issuecomment-469129412, realtime features and other. you can find more on 'query log cosmetic changes'
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/AdGuardHome#1639
No description provided.