mirror of
https://github.com/AdguardTeam/AdGuardHome.git
synced 2026-03-04 00:01:12 -05:00
Adding custom filtering rules with block/unblock buttons returns 405 errors #641
Labels
No labels
P1: Critical
P2: High
P3: Medium
P4: Low
UI
bug
cannot reproduce
compatibility
dependencies
docker
documentation
duplicate
enhancement
enhancement
external libs
feature request
good first issue
help wanted
infrastructure
invalid
localization
needs investigation
performance
potential-duplicate
question
recurrent
research
snap
waiting for data
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/AdGuardHome#641
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @rfgamaral on GitHub (Apr 10, 2019).
Steps to reproduce
set_rules.Expected behavior
Block/Unblock rules should be added to custom filtering rules without any errors.
Actual behavior
Block/Unblock rules are added to custom filtering rules but popup errors still show up.
Screenshot:
Your environment
@rfgamaral commented on GitHub (Apr 10, 2019):
Probably related... Editing custom filtering rules manually and clicking "Apply", returns the same 405 error and my AdGuard Home Docker container crashes. Rules seem to be saved to the config file but it still crashes and returns 405 errors.
@ameshkov commented on GitHub (Apr 10, 2019):
Hm, I cannot reproduce this.
Also,
405means "Method not allowed". I suspect you have some reverse proxy in front of AdGuard Home that does not acceptPUTmethod. Do you have any?@rfgamaral commented on GitHub (Apr 11, 2019):
Yes, I do have a reverse proxy in front of AdGuard (there are no options to configure what's allowed or not). However, I also tested this connected directly to the source IP:PORT, same issue.
@ameshkov commented on GitHub (Apr 11, 2019):
I just don't see any place in the code where we return error code 405.
Although, I guess we should stick to GET and POST to avoid issues with proxies.
@rfgamaral commented on GitHub (Apr 11, 2019):
That solves it?
However, how do you explain this problem when accessing without the proxy?
@ameshkov commented on GitHub (Apr 11, 2019):
I think it does, but we'll have to check once it's ready.
Is it still a 405 error? Then there is still a proxy (no idea how so, though).
@rfgamaral commented on GitHub (Apr 11, 2019):
Actually, I have a different error:
http://192.168.0.253:3000(direct connection)The
PUTrequest doesn't even finish here...https://adguard.custom.domain/(nginx reverse proxy)The
PUTrequest returns405.I just did further testing and I'm almost positive the problem is not the reverse proxy...
I installed AdGuard Home in a second work and I no longer had this issue. In fact, this new container also "fixed" issue #703 that I opened a few days ago. This is probably a problem in my network setup.
What's the difference between these 2 containers? Well, this new Docker container network was set to
hostwhile the other one was using themacvlandriver. The idea here was to have a specific IP (different from the container host) for the DNS server:This is probably causing all these issues, I'm just not sure exactly what it is...
@rfgamaral commented on GitHub (Apr 11, 2019):
Ok, I'm really confused about a lot of things right now and I'm not sure what's going. Please allow me to do further testing and review all this properly. I'll post back my results when I'm bit more sure of what is actually working and what is not.
@rfgamaral commented on GitHub (Apr 11, 2019):
Closing since the actual issue was #713.