Cannot disable images in emby metadata #5517

Closed
opened 2026-02-19 22:59:37 -05:00 by deekerman · 2 comments
Owner

Originally created by @edrock200 on GitHub (Jan 30, 2021).

Describe the bug
On the last develop release as well as the last week or so of nightlys for radarr, if metadata for emby is enabled, you can't untick the poster option. If you untick and save it auto reticks.
To Reproduce
Enable emby/kodi metadata with nfo and images. Click save. Open up again and untick images, click save. If you open it again, posters is still ticked. It won't apply with images disabled.

Expected behavior
Images can be disabled with nfos enabled.

Platform Information (please complete the following information):

  • OS: Ubuntu 18.04
  • Docker: Yes
  • .NET (5.0.2)
  • Browser and Version - reproducible on mobile and desktop chrome and desktop IE
  • Radarr Version: 3.0.2.4504-ls11 by linuxserver.io
  • Radarr Branch: nightly (started on develop, switched to nightly to see if it would fix, can't revert because nightly seems to have updated the database and get db error if I revert.)

Trace Logs
https://pastebin.com/51Wr39jV

I have reproduced this on two of my radarr instances as well as two of a friend's that are on completely different setups. Thanks in advance!

Originally created by @edrock200 on GitHub (Jan 30, 2021). <!-- Support Requests will be closed immediately, if you are unsure go to our Reddit or Discord first. Exceptions do not mean you found a bug! --> **Describe the bug** On the last develop release as well as the last week or so of nightlys for radarr, if metadata for emby is enabled, you can't untick the poster option. If you untick and save it auto reticks. **To Reproduce** Enable emby/kodi metadata with nfo and images. Click save. Open up again and untick images, click save. If you open it again, posters is still ticked. It won't apply with images disabled. **Expected behavior** Images can be disabled with nfos enabled. **Platform Information (please complete the following information):** - OS: Ubuntu 18.04 - Docker: Yes - .NET (5.0.2) - Browser and Version - reproducible on mobile and desktop chrome and desktop IE - Radarr Version: 3.0.2.4504-ls11 by linuxserver.io - Radarr Branch: nightly (started on develop, switched to nightly to see if it would fix, can't revert because nightly seems to have updated the database and get db error if I revert.) **Trace Logs** https://pastebin.com/51Wr39jV I have reproduced this on two of my radarr instances as well as two of a friend's that are on completely different setups. Thanks in advance!
Author
Owner

@Qstick commented on GitHub (Feb 7, 2021):

@ta264 this is DB mapper related, it's only saving "true" values for checkboxes on Provider Settings fields

Change to false

Object is correct at ProviderModuleBase L96:

image

Then what gets put in the DB:

{
  "movieMetadata": true,
  "movieMetadataLanguage": 1,
  "isValid": true
}

This is troublesome as the default value for MovieImages is true, thus when its not saved to DB as false, it picks up true. Meaning you can never toggle it to false. Map to object thing again?

@Qstick commented on GitHub (Feb 7, 2021): @ta264 this is DB mapper related, it's only saving "true" values for checkboxes on Provider Settings fields Change to false Object is correct at ProviderModuleBase L96: ![image](https://user-images.githubusercontent.com/376117/107161981-459a6f00-696e-11eb-914e-93f38b2ddeee.png) Then what gets put in the DB: ``` { "movieMetadata": true, "movieMetadataLanguage": 1, "isValid": true } ``` This is troublesome as the default value for MovieImages is true, thus when its not saved to DB as false, it picks up true. Meaning you can never toggle it to false. Map to object thing again?
Author
Owner

@Qstick commented on GitHub (Feb 7, 2021):

Changing to Ignore when Null instead of Default seems to fix, assuming that fine elsewhere
image

@Qstick commented on GitHub (Feb 7, 2021): Changing to Ignore when Null instead of Default seems to fix, assuming that fine elsewhere ![image](https://user-images.githubusercontent.com/376117/107162191-85ae2180-696f-11eb-8ef0-24674c2db3a6.png)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/Radarr#5517
No description provided.