mirror of
https://github.com/Radarr/Radarr.git
synced 2026-03-02 22:57:34 -05:00
Cannot disable images in emby metadata #5517
Labels
No labels
Area: API
Area: Database
Area: Db-migration
Area: Download Clients
Area: Extras
Area: Import Lists
Area: Indexer
Area: Metadata API
Area: Notifications
Area: Organizer
Area: Parser
Area: Scanning
Area: Tooling
Area: UI
Area: Unit Tests
On Hold: MetadataAPI Blocking
On Hold: MetadataAPI Blocking
Priority: High
Priority: Low
Priority: Medium
Status: Accepted
Status: Cannot Reproduce
Status: Confirmed
Status: Help Wanted
Status: In Progress
Status: Indexer - need invite
Status: Info Needed
Status: Investigating
Status: Logs Needed
Status: Maybe One Day
Status: Needs Triage
Status: On Hold
Status: Ready for Review
Status: Unlikely
Status: Waiting for OP
Status: Won't Fix
Type: Bug
Type: Documentation
Type: Duplicate
Type: Enhancement
Type: External Bug
Type: Feature Request
Type: Regression
Type: Support
Type: Support.
conflict
lidarr-pull
no-conflict
not-pulled
readarr-pull
readarr-pull
sonarr upstream
sonarr-pull
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/Radarr#5517
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @edrock200 on GitHub (Jan 30, 2021).
Describe the bug
On the last develop release as well as the last week or so of nightlys for radarr, if metadata for emby is enabled, you can't untick the poster option. If you untick and save it auto reticks.
To Reproduce
Enable emby/kodi metadata with nfo and images. Click save. Open up again and untick images, click save. If you open it again, posters is still ticked. It won't apply with images disabled.
Expected behavior
Images can be disabled with nfos enabled.
Platform Information (please complete the following information):
Trace Logs
https://pastebin.com/51Wr39jV
I have reproduced this on two of my radarr instances as well as two of a friend's that are on completely different setups. Thanks in advance!
@Qstick commented on GitHub (Feb 7, 2021):
@ta264 this is DB mapper related, it's only saving "true" values for checkboxes on Provider Settings fields
Change to false
Object is correct at ProviderModuleBase L96:
Then what gets put in the DB:
This is troublesome as the default value for MovieImages is true, thus when its not saved to DB as false, it picks up true. Meaning you can never toggle it to false. Map to object thing again?
@Qstick commented on GitHub (Feb 7, 2021):
Changing to Ignore when Null instead of Default seems to fix, assuming that fine elsewhere
