mirror of
https://github.com/rustdesk/rustdesk.git
synced 2026-03-02 19:26:56 -05:00
Sign rustdesk files failing in Windows x86_64 #2497
Labels
No labels
bug
documentation
duplicate
enhancement
enhancement
enhancement
good first issue
help wanted
invalid
question
unreproducible
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/rustdesk-rustdesk#2497
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @chris-notley on GitHub (Feb 21, 2024).
Bug Description
We have previously been able to sign the Windows installer with our code signing certificate. Following the response from @deep-soft in issue #6549 it started working again now.
The Windows x86_64 job is now failing with the following error
(attaching an image in screenshot section too)
We can see the certificate imports successfully, but it can't find the files to sign by the looks of it.
In terms of modification, we have removed some self-signed jobs from the build file and made the changes identified in #6549.
How to Reproduce
Run the nightly build with a code signing certificate and the following secrets defined:
Expected Behavior
Signing to complete successfully.
Operating system(s) on local side and remote side
Windows 11 -> CI
RustDesk Version(s) on local side and remote side
Nightly as of 20240221
Screenshots
Additional Context
No response
@rustdesk commented on GitHub (Feb 21, 2024):
#763
@deep-soft commented on GitHub (Feb 21, 2024):
use:
folder:
./flutter/build/windows/x64/runner/Release/from this PR:
https://github.com/rustdesk/rustdesk/pull/7209
or this commit:
github.com/rustdesk/rustdesk@7b317619ac@chris-notley commented on GitHub (Feb 21, 2024):
Thanks @deep-soft!