starred/virtualtabletop

Fork 0

mirror of https://github.com/ArnoldSmith86/virtualtabletop.git synced 2026-03-02 22:57:02 -05:00

Array comparison fails #304

New issue

Open

opened 2026-02-20 10:16:17 -05:00 by deekerman · 7 comments

deekerman commented

2026-02-20 10:16:17 -05:00

Owner

Originally created by @rogerl50 on GitHub (Jul 2, 2021).

The following clickRoutine:

  "clickRoutine": [
    {
      "func": "IF",
      "operand1": [],
      "relation": "==",
      "operand2": [],
      "thenRoutine": [
        "var equal = true"
      ],
      "elseRoutine": [
        "var equal = false"
      ]
    }
  ],

takes the else branch.

Originally created by @rogerl50 on GitHub (Jul 2, 2021). The following `clickRoutine`: ``` "clickRoutine": [ { "func": "IF", "operand1": [], "relation": "==", "operand2": [], "thenRoutine": [ "var equal = true" ], "elseRoutine": [ "var equal = false" ] } ], ``` takes the `else` branch.

deekerman added the

needs legacy server

label

2026-02-20 10:16:17 -05:00

deekerman commented

2026-02-20 10:16:18 -05:00

Author

Owner

@robartsd commented on GitHub (Jul 2, 2021):

All object comparisons fail because we test === instead of ==.

@robartsd commented on GitHub (Jul 2, 2021): All object comparisons fail because we test `===` instead of `==`.

deekerman commented

2026-02-20 10:16:18 -05:00

Author

Owner

@rogerl50 commented on GitHub (Jul 2, 2021):

So I guess I need to get the length of the array I'm comparing to [] and compare that to zero, unless there's a better way.

@rogerl50 commented on GitHub (Jul 2, 2021): So I guess I need to get the length of the array I'm comparing to `[]` and compare that to zero, unless there's a better way.

deekerman commented

2026-02-20 10:16:18 -05:00

Author

Owner

@robartsd commented on GitHub (Jul 2, 2021):

So I guess I need to get the length of the array I'm comparing to [] and compare that to zero, unless there's a better way.

For now, yes. Discuss issue in #615.

@robartsd commented on GitHub (Jul 2, 2021): > So I guess I need to get the length of the array I'm comparing to `[]` and compare that to zero, unless there's a better way. For now, yes. Discuss issue in #615.

deekerman commented

2026-02-20 10:16:18 -05:00

Author

Owner

@rogerl50 commented on GitHub (Jul 2, 2021):

Should this issue be linked to #615, or just closed?

@rogerl50 commented on GitHub (Jul 2, 2021): Should this issue be linked to #615, or just closed?

deekerman commented

2026-02-20 10:16:18 -05:00

Author

Owner

@robartsd commented on GitHub (Jul 2, 2021):

I was mistaken IF does use == only SELECT is using === currently. But it looks like == does not return true for arrays unless they are the same object. Perhaps we should implement a deep comparison of objects as I believe we would like == to return true in this case.

@robartsd commented on GitHub (Jul 2, 2021): I was mistaken `IF` does use `==` only `SELECT` is using `===` currently. But it looks like `==` does not return true for arrays unless they are the same object. Perhaps we should implement a deep comparison of objects as I believe we would like `==` to return true in this case.

deekerman commented

2026-02-20 10:16:18 -05:00

Author

Owner

@ArnoldSmith86 commented on GitHub (Jul 2, 2021):

Not sure. Another solution is to offer JSON stringify and parse and let the user compare that instead.

Doing that automatically in == might be OK though. The normal behavior is probably never useful for us.

@ArnoldSmith86 commented on GitHub (Jul 2, 2021): Not sure. Another solution is to offer JSON stringify and parse and let the user compare that instead. Doing that automatically in == might be OK though. The normal behavior is probably never useful for us.

deekerman commented

2026-02-20 10:16:18 -05:00

Author

Owner

@robartsd commented on GitHub (Jul 2, 2021):

Of course for objects, JSON stringify could still be inadequate as the key order is not guaranteed. We might want to turn to something like https://github.com/substack/json-stable-stringify (could also be useful for TestCafe checks, but I don't think we've yet run into issues where key insertion order has caused problems there).

@robartsd commented on GitHub (Jul 2, 2021): Of course for objects, JSON stringify could still be inadequate as the key order is not guaranteed. We might want to turn to something like https://github.com/substack/json-stable-stringify (could also be useful for TestCafe checks, but I don't think we've yet run into issues where key insertion order has caused problems there).